Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Remove commented out platforms from matrix_from_metadata #554

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

david22swan
Copy link
Member

Summary

Cleanup and remove commented out platforms.
Support for them was removed previously but they were left as comments for reasons unremembered

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan requested a review from a team as a code owner April 26, 2024 11:23
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.04%. Comparing base (d581c89) to head (30cc692).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   63.04%   63.04%           
=======================================
  Files           6        6           
  Lines         763      763           
=======================================
  Hits          481      481           
  Misses        282      282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 merged commit b4e61e0 into main Apr 26, 2024
8 checks passed
@jordanbreen28 jordanbreen28 deleted the cleanup_extract branch April 26, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants