Minor install_module improvements #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if target_node_name option is not given, the default is all targets, but the confirmation output is blank
h0tw1r3
force-pushed
the
module-install
branch
from
0215e0f to
f77d172
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
+ Coverage 61.64% 63.04% +1.39%
==========================================
Files 6 6
Lines 764 763 -1
==========================================
+ Hits 471 481 +10
+ Misses 293 282 -11 ☔ View full report in Codecov by Sentry. |
install each module to nodes in parallel
|
@jordanbreen28 if you have a moment, can you review please? |
|
hey @h0tw1r3 - apologies, was off for a few days there.. |
jordanbreen28
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installed <module> onmessage when install_module on all targets