Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxd provisioner support #544

Merged
merged 1 commit into from
May 23, 2024
Merged

lxd provisioner support #544

merged 1 commit into from
May 23, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Jan 30, 2024 •
edited
Loading

@h0tw1r3 h0tw1r3 requested a review from a team as a code owner January 30, 2024 11:54
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.64%. Comparing base (2e0b5c7) to head (b2cd9a3).

❗ Current head b2cd9a3 differs from pull request most recent head a1eb0f8. Consider uploading reports for the commit a1eb0f8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   63.95%   61.64%   -2.31%     
==========================================
  Files           6        6              
  Lines         763      764       +1     
==========================================
- Hits          488      471      -17     
- Misses        275      293      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h0tw1r3 h0tw1r3 force-pushed the lxd branch 3 times, most recently from b2cd9a3 to 7b759f1 Compare February 8, 2024 17:40
@h0tw1r3 h0tw1r3 requested a review from a team as a code owner February 8, 2024 17:40
@h0tw1r3 h0tw1r3 marked this pull request as draft April 30, 2024 14:36
@h0tw1r3 h0tw1r3 marked this pull request as ready for review May 17, 2024 16:42
LukasAud
LukasAud approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit c541934 into puppetlabs:main May 23, 2024
6 checks passed
@h0tw1r3 h0tw1r3 deleted the lxd branch May 31, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h0tw1r3 @LukasAud