Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jekyll-gh-pages.yml #398

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Create jekyll-gh-pages.yml #398

merged 1 commit into from
Jun 26, 2024

Conversation

gavindidrichsen
Copy link
Contributor

@gavindidrichsen gavindidrichsen commented Jun 25, 2024

Summary

As a devx developer I want to publish GH Pages for several repositories. The gh pages documentation is detailed. The following key points contributed to my decision to add this change:

  • Currently there a 2 ways to generate GH Pages on a repository. The documentation calls these "sources". One is a manual push; the other uses a special github action deployment workflow.
  • After June 2024, only the github action source will be used.
  • Best practice around documentation is that (1) a special github "environment" should be created called "github-pages" and (2) a unique branch "gh-pages" should be created alongside the "main". The environment is a set of rules that limits documentation deployments from specific branches and the unique branch means that "code" and site-documentation are kept separate.

Therefore, I created the github-pages environment, the gh-pages branch, and the github action workflow defined in this PR

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.88%. Comparing base (cbd6f81) to head (afdad0e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   70.88%   70.88%           
=======================================
  Files          78       78           
  Lines        2483     2483           
=======================================
  Hits         1760     1760           
  Misses        723      723           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavindidrichsen gavindidrichsen marked this pull request as ready for review June 26, 2024 08:58
@gavindidrichsen gavindidrichsen requested review from bastelfreak and a team as code owners June 26, 2024 08:58
As a devx developer I want to publish GH Pages for several repositories.  The [gh pages documentation](https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages) is detailed.  The following key points contributed to my decision to add this change:
* Currently there a 2 ways to generate GH Pages on a repository.  The documentation calls these "sources".  One is a manual push; the other uses a special github action deployment workflow.
* After June 2024, only the github action source will be used.
* Best practice around documentation is that (1) a special github "environment" should be created called "github-pages" and (2) a unique branch "gh-pages" should be created alongside the "main".  The environment is a set of rules that limits documentation deployments from specific branches and the unique branch means that "code" and site-documentation are kept separate.

Therefore, I created the github-pages environment, the gh-pages branch, and the github action workflow defined in this PR
@david22swan david22swan merged commit 302ed23 into main Jun 26, 2024
11 checks passed
@david22swan david22swan deleted the cat_1930_gh_pages branch June 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants