(PE-39261) add configurations for 2023.8.x #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmburgan
reviewed
Sep 9, 2024
|
|
||
| # Common settings | ||
| instance_eval File.read(File.join(File.dirname(__FILE__), '_shared-client-tools-runtime.rb')) | ||
| end |
There was a problem hiding this comment.
Indent got a little extra indent-y
There was a problem hiding this comment.
Actually I think all of them are
This adds specific configurations for client-tools, pe-bolt-server, and pe-installer based on the main configuration for 2023.8.x
v1 and v2 of the upload-artifact are no longer available. This updates to version 4.
jonathannewman
force-pushed
the
PE-39261/master/add-2023.8.x
branch
from
4760524
to
739815f
Compare
nmburgan
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds specific configurations for client-tools, pe-bolt-server, and pe-installer based on the main configuration for 2023.8.x