(PA-6896) Enable pie on RHEL 9 and up #906
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(PA-6896) remove the shared flag
joshcooper
reviewed
Sep 6, 2024
| @@ -21,4 +20,9 @@ | |||
| proj.setting(:cppflags, "-I#{proj.includedir} -D_FORTIFY_SOURCE=2") | |||
| proj.setting(:cflags, '-fstack-protector-strong -fno-plt -O2') | |||
| proj.setting(:ldflags, "-L#{proj.libdir} -Wl,-rpath=#{proj.libdir},-z,relro,-z,now") | |||
| elsif(platform.is_el? && platform.os_version.to_i >= 8) | |||
There was a problem hiding this comment.
Suggested change
| elsif(platform.is_el? && platform.os_version.to_i >= 8) | |
| elsif platform.is_el? && platform.os_version.to_i >= 8 |
| @@ -94,7 +94,7 @@ | |||
| special_flags = " --prefix=#{ruby_dir} --with-opt-dir=#{settings[:prefix]} " | |||
|
|
|||
| if settings[:supports_pie] | |||
| special_flags += " CFLAGS='#{settings[:cflags]}' LDFLAGS='#{settings[:ldflags]}' CPPFLAGS='#{settings[:cppflags]}' " | |||
| special_flags += " CFLAGS='-fPIC -fstack-protector-strong -fno-plt -O2' LDFLAGS='#{settings[:ldflags]}' CPPFLAGS='-fPIE #{settings[:cppflags]}' " | |||
There was a problem hiding this comment.
Can you describe why you're removing :cflags from here? What problem is being solved aside from "pie doesn't work"? Does this mean none of the cflags defined in the project are being passed to the configure command?
| @@ -12,7 +12,6 @@ | |||
| # are too old to support these flags. | |||
|
|
|||
| if((platform.is_sles? && platform.os_version.to_i >= 15) || | |||
| (platform.is_el? && platform.os_version.to_i == 8 && platform.architecture !~ /ppc64/) || | |||
There was a problem hiding this comment.
Does this mean RHEL 9 ppc now supports pie? If so, the commit message should mention the change in behavior.
|
Oh sorry I just noticed this is a draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PA-6896) remove the shared flag