(CAT-1869) - Add puppet-modulebuilder to pdk bundled gems #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
added
the
maintenance
jordanbreen28
force-pushed
the
cat-1869-add_puppet-modulebuilder_gem
branch
2 times, most recently
from
be1c5a3
to
3b0cec7
Compare
jordanbreen28
force-pushed
the
cat-1869-add_puppet-modulebuilder_gem
branch
4 times, most recently
from
089f7f5
to
0fd6b2e
Compare
jordanbreen28
force-pushed
the
cat-1869-add_puppet-modulebuilder_gem
branch
from
0fd6b2e
to
fb2676a
Compare
This commit adds the puppet-modulebuilder gem to the gems bundled with the pdk. This gem is no required for the module build functionality.
jordanbreen28
force-pushed
the
cat-1869-add_puppet-modulebuilder_gem
branch
from
fb2676a
to
19f43c7
Compare
jordanbreen28
added
help wanted
joshcooper
reviewed
Jul 10, 2024
joshcooper
approved these changes
Jul 10, 2024
|
Sorry forgot one thing, could you make sure you can build the pdk runtime on all supported platforms using Vanagon Generic Builder before merging? The reason is each commit to the runtime causes all runtimes to be rebuilt |
|
Thanks @joshcooper! Going off the other PRs to this repo, here's my best attempt at that.. |
david22swan
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the puppet-modulebuilder gem to the gems bundled with the pdk. This gem is now required for the module build functionality.