(PA-6543) Bump wix to 3.14.1 for puppet-agent 7.x #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamshinde360
force-pushed
the
PA-6543-7x
branch
from
8a4f56e
to
552c8d6
Compare
|
The build succeeds and all impacted windows platforms pass ad-hoc integration tests: |
joshcooper
reviewed
Sep 13, 2024
shubhamshinde360
force-pushed
the
PA-6543-7x
branch
from
552c8d6
to
5f6c739
Compare
We use '--ignore-dependencies' flag to install wixtoolset since it depends on DotNet3.5 which breaks when installing: wixtoolset/issues#5523. Seems we don't need it for our use case, we can leave it out.
shubhamshinde360
force-pushed
the
PA-6543-7x
branch
from
5f6c739
to
cd5a60f
Compare
joshcooper
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use '--ignore-dependencies' flag to install wixtoolset since it depends on DotNet3.5 which breaks when installing: wixtoolset/issues#5523. Seems we don't need it for our use case, we can leave it out.