Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CDPE-6575) - update logo viewBox size #659

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

danadoherty639
Copy link
Contributor

@danadoherty639 danadoherty639 commented Mar 25, 2024

Update the viewBox size for CD4PE logo

image

@danadoherty639 danadoherty639 marked this pull request as ready for review March 25, 2024 10:39
@danadoherty639 danadoherty639 requested a review from a team as a code owner March 25, 2024 10:39
CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## react-components 5.34.5 (2024-03-25)

- [Logo] Bug fixing continuous delivery logo (by [@danadoherty639](https://github.com/danadoherty639))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more descriptive here?

Copy link
Contributor

@mttsltrs mttsltrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although I'm not sure the data-grid/package-lock.json file should be committed if there were no changes to its package.json

@sean-mckenna
Copy link
Collaborator

Look like there might be an issue with changes in packages/data-grid/package-lock.json? Maybe check you are on the right version of node

@danadoherty639 danadoherty639 merged commit b13d64e into main Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants