Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) - gem_ci.yml fix Unrecognized named-value: secrets #90

Merged
merged 1 commit into from
May 17, 2024

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented May 17, 2024

The secrets context is not available to GHA conditionals. Update to write the secret to an ENV variable, which we can then check isn't an empty string.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Available expression contexts: github, inputs, vars, needs, strategy, matrix, steps, job, runner, env

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

The secrets context is not available to GHA conditionals. Update to
write the secret to an ENV variable, which we can then check isn't an
empty string.
@jordanbreen28 jordanbreen28 added the bug Something isn't working label May 17, 2024
@jordanbreen28 jordanbreen28 marked this pull request as ready for review May 17, 2024 11:04
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner May 17, 2024 11:04
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 36be3e4 into main May 17, 2024
2 checks passed
@david22swan david22swan deleted the bug-fix_Unrecognized_named-value branch May 17, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants