Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) - Remove third party rubygems registry dependency #69

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

jordanbreen28
Copy link
Contributor

Prior to this PR, we relied on actionshub/publish-gem-to-github. This action would swallow exit codes, and falsely report successful steps on non-zero exit code.

We have decided to take a manual approach, where we can essentially do this ourselves and ensure the maintenace of this step.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 added the bug Something isn't working label Dec 5, 2023
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner December 5, 2023 11:59
@jordanbreen28 jordanbreen28 force-pushed the maint-remove_github_rubygems branch 10 times, most recently from d19f997 to bcd205a Compare December 5, 2023 12:49
Prior to this commit, we relied on actionshub/publish-gem-to-github.
This action would swallow exit codes, and falsely report successful
steps on non-zero exit code.

We have decided to take a manual approach, where we can essentially do
this ourselves and ensure the maintenace of this step.
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavindidrichsen gavindidrichsen merged commit 9c7ade7 into main Dec 5, 2023
2 checks passed
@gavindidrichsen gavindidrichsen deleted the maint-remove_github_rubygems branch December 5, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants