(CONT-1129) - Overriding default time for acceptace runs #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramesh7
commented
Jun 26, 2023
| @@ -55,6 +55,7 @@ jobs: | |||
| name: "Acceptance tests (${{matrix.platforms.label}}, ${{matrix.collection}})" | |||
| needs: "setup_matrix" | |||
| runs-on: ${{ inputs.runs_on }} | |||
| timeout-minutes: 180 | |||
There was a problem hiding this comment.
Duration is in minutes.
jordanbreen28
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have seen that many Nightly and CI actions runs for 6 hours (default timeout of GitHub actions) and it aborted but the provision server terminated in 2 hours from the provision but still GitHub action keep running.
Change
Overriding default timeout of action and set to 3 hours as haven't observed any job taking more then 2 hours so updating with 3 hour keeping 1 hour buffer.
Benefit
Overriding default time will help us to avoid running jobs for default timeout as well as it will also save cost.