Naming params added custom response code #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added status code from response to to method response exception
pulzarraider
requested changes
Jan 18, 2018
| @@ -20,6 +20,10 @@ | |||
| abstract class Implementation | |||
| { | |||
|
|
|||
| const ERROR_STATUS_CODE = 500; | |||
There was a problem hiding this comment.
Symfony Response has its own statuc code constants: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Response.php#L21-L82 since Symfony 2.4
https://symfony.com/blog/new-in-symfony-2-4-using-constants-for-http-status-code
There is no reason to define same own constants.
| @@ -25,6 +25,8 @@ | |||
|
|
|||
| class Server implements ServerInterface | |||
| { | |||
| const HTTP_SUCCESS_STATUS = 200; | |||
There was a problem hiding this comment.
Please use Symfony's response constants and remove this.
| * @param int $code Error code (default = 0) | ||
| * @param int $httpStatusCode HTTP status code to send (default = 400) | ||
| */ | ||
| public function __construct($message, $code = 0, $httpStatusCode = 400) |
There was a problem hiding this comment.
The __construct must always be the first method to increase readability according to https://symfony.com/doc/current/contributing/code/standards.html
| } | ||
|
|
||
| if (empty($data['jsonrpc']) || version_compare($data['jsonrpc'], '2.0', '<')) { | ||
| throw new InvalidJsonRpcVersion('The JSON-RPC call version is not supported', self::ERROR_SERVER_ERROR); | ||
| throw new InvalidJsonRpcVersion('The JSON-RPC call version is not supported', self::ERROR_SERVER_ERROR, self::ERROR_INVALID_REQUEST); |
There was a problem hiding this comment.
self::ERROR_INVALID_REQUEST is not a status code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.