Update guestbook frontend image used for testing #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2689 +/- ##
=======================================
Coverage 18.62% 18.62%
=======================================
Files 47 47
Lines 9589 9589
=======================================
Hits 1786 1786
Misses 7699 7699
Partials 104 104 ☔ View full report in Codecov by Sentry. |
The `gcr.io/google-samples/gb-frontend:v4` image was deleted from the container registry. The new image was obtained from the GoogleCloudPlatform repository: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples. Ref: https://cloud.google.com/kubernetes-engine/docs/tutorials/guestbook
rquitales
force-pushed
the
rquitales/test-no-op
branch
from
6c5eb06 to
ba8fac3
Compare
rquitales
changed the title
rquitales
added
the
impact/no-changelog-required
rquitales
commented
Dec 5, 2023
| @@ -36,7 +36,8 @@ private ConfigFile MakeConfigFile(string name, string namespaceName, Provider pr | |||
| { | |||
| return new ConfigFile(name, new ConfigFileArgs | |||
| { | |||
| File = "https://raw.githubusercontent.com/pulumi/pulumi-kubernetes/master/tests/sdk/nodejs/examples/yaml-guestbook/yaml/guestbook.yaml", | |||
| // TODO: Switch back to master branch once the guestbook.yaml file is merged into mainline branch. | |||
There was a problem hiding this comment.
CI for this PR presubmit will fail if we don't update the URL to point away from master, since the checked in manifest in master is not updated yet. I'm not sure what the best way to handle this, but switching to the current commit's manifest then following up with another PR to update it to the latest in master will quickly unblock us for now.
EronWright
approved these changes
Dec 5, 2023
rquitales
force-pushed
the
rquitales/test-no-op
branch
from
9bf1566 to
c80ef62
Compare
rquitales
added a commit
that referenced
this pull request
Dec 15, 2023
The `gcr.io/google-samples/gb-frontend:v4` image was deleted from the container registry. The new image was obtained from the GoogleCloudPlatform repository: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples. Ref: https://cloud.google.com/kubernetes-engine/docs/tutorials/guestbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gcr.io/google-samples/gb-frontend:v4image was deleted from the container registry. The new image was obtained from the GoogleCloudPlatform repository: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples.Ref: https://cloud.google.com/kubernetes-engine/docs/tutorials/guestbook