Separate pull request flow #11849
Merged
Separate pull request flow #11849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your site preview for commit 89b2e93 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-11849-89b2e930.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 6d201cb is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-11849-6d201cb2.s3-website.us-west-2.amazonaws.com. |
cnunciato
reviewed
May 17, 2024
cnunciato
reviewed
May 17, 2024
cnunciato
approved these changes
May 17, 2024
good point! I think you may be right. I'll test it out and see. |
|
Your site preview for commit adf5aca is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-11849-adf5aca8.s3-website.us-west-2.amazonaws.com. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates pull request flow from the build and deploy workflow and stand up a separate cleanup job for the testing environment, since that is where previews will live.
This separation will enable us to turn add the sync job to
docs-private. It will only run the PR workflows and we can jsut disable the build-and-deploy workflow there so there will be no deploys from that repo, only PR builds. That repo does not have access to the prod environment, so can't really mess up anything there.