-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace apb soc ctrl #89
Draft
meggiman
wants to merge
31
commits into
master
Choose a base branch
from
replace_apb_soc_ctrl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed fc_eu signals to fc_interrupts to make a clear distinction between events and interrupts. - Removed old APB crossbar and replaced it with integrated crossbar in AXI-lite to APB converter. Moved address definitions from peripheral_bud_defines to soc_mem_maps.svh
Was not connected anywhere in the first place
depends on #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing apb_soc_ctrl register file in
soc_peripherals
is extremely cumbersome to modify and causes tons of linter warnings. This PR replaces the old regfile with an auto-generated register file using reggen. Where appropriate, the existing registers were ported using the same address offsets to remain compatible with existing software. Some registers that no longer served any purpose were committed while some completely new registers were added. pulp_soc now contains a Makefile to quickly regenerate the register file RTL from a modified regfile hjson inrtl/pulp_soc/soc_ctrl_reg
.