Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add gearing to the memory island #9

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

WIP: add rready wrap

58f7575
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

WIP: Add gearing to the memory island #9

WIP: add rready wrap
58f7575
Select commit
Loading
Failed to load commit list.
GitHub Actions / verible-verilog-lint failed Aug 22, 2024 in 0s

reviewdog [verible-verilog-lint] report

reported by reviewdog 🐶

Findings (15)

src/geared_memory_island.sv|47 col 26| Explicitly define a storage type for every parameter and localparam, (MemorySimInit). [Style: constants] [explicit-parameter-storage-type]
src/geared_memory_island.sv|177 col 44| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_memory_island.sv|178 col 18| Explicitly define a storage type for every parameter and localparam, (id). [Style: constants] [explicit-parameter-storage-type]
src/geared_memory_island.sv|262 col 44| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_memory_island.sv|263 col 18| Explicitly define a storage type for every parameter and localparam, (id). [Style: constants] [explicit-parameter-storage-type]
src/geared_stream_split.sv|28 col 22| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_stream_split.sv|30 col 32| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_stream_split.sv|35 col 12| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_stream_split.sv|50 col 44| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_stream_collect.sv|28 col 22| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_stream_collect.sv|30 col 32| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_stream_collect.sv|34 col 12| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_stream_collect.sv|55 col 44| All generate block statements must have a label [Style: generate-statements] [generate-label]
src/geared_stream_collect.sv|62 col 101| Line length exceeds max: 100; is: 126 [Style: line-length] [line-length]
src/geared_stream_collect.sv|63 col 101| Line length exceeds max: 100; is: 110 [Style: line-length] [line-length]

Filtered Findings (0)

Annotations

Check warning on line 47 in src/geared_memory_island.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_memory_island.sv#L47

Explicitly define a storage type for every parameter and localparam, (MemorySimInit). [Style: constants] [explicit-parameter-storage-type]
Raw output
message:"Explicitly define a storage type for every parameter and localparam, (MemorySimInit). [Style: constants] [explicit-parameter-storage-type]"  location:{path:"./src/geared_memory_island.sv"  range:{start:{line:47  column:26}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 177 in src/geared_memory_island.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_memory_island.sv#L177

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_memory_island.sv"  range:{start:{line:177  column:44}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 178 in src/geared_memory_island.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_memory_island.sv#L178

Explicitly define a storage type for every parameter and localparam, (id). [Style: constants] [explicit-parameter-storage-type]
Raw output
message:"Explicitly define a storage type for every parameter and localparam, (id). [Style: constants] [explicit-parameter-storage-type]"  location:{path:"./src/geared_memory_island.sv"  range:{start:{line:178  column:18}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 262 in src/geared_memory_island.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_memory_island.sv#L262

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_memory_island.sv"  range:{start:{line:262  column:44}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 263 in src/geared_memory_island.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_memory_island.sv#L263

Explicitly define a storage type for every parameter and localparam, (id). [Style: constants] [explicit-parameter-storage-type]
Raw output
message:"Explicitly define a storage type for every parameter and localparam, (id). [Style: constants] [explicit-parameter-storage-type]"  location:{path:"./src/geared_memory_island.sv"  range:{start:{line:263  column:18}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 28 in src/geared_stream_split.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_split.sv#L28

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_stream_split.sv"  range:{start:{line:28  column:22}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 30 in src/geared_stream_split.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_split.sv#L30

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_stream_split.sv"  range:{start:{line:30  column:32}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 35 in src/geared_stream_split.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_split.sv#L35

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_stream_split.sv"  range:{start:{line:35  column:12}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 50 in src/geared_stream_split.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_split.sv#L50

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_stream_split.sv"  range:{start:{line:50  column:44}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 28 in src/geared_stream_collect.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_collect.sv#L28

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_stream_collect.sv"  range:{start:{line:28  column:22}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 30 in src/geared_stream_collect.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_collect.sv#L30

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_stream_collect.sv"  range:{start:{line:30  column:32}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 34 in src/geared_stream_collect.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_collect.sv#L34

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_stream_collect.sv"  range:{start:{line:34  column:12}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 55 in src/geared_stream_collect.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_collect.sv#L55

All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]"  location:{path:"./src/geared_stream_collect.sv"  range:{start:{line:55  column:44}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 62 in src/geared_stream_collect.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_collect.sv#L62

Line length exceeds max: 100; is: 126 [Style: line-length] [line-length]
Raw output
message:"Line length exceeds max: 100; is: 126 [Style: line-length] [line-length]"  location:{path:"./src/geared_stream_collect.sv"  range:{start:{line:62  column:101}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}

Check warning on line 63 in src/geared_stream_collect.sv

See this annotation in the file changed.

@github-actions github-actions / verible-verilog-lint

[verible-verilog-lint] src/geared_stream_collect.sv#L63

Line length exceeds max: 100; is: 110 [Style: line-length] [line-length]
Raw output
message:"Line length exceeds max: 100; is: 110 [Style: line-length] [line-length]"  location:{path:"./src/geared_stream_collect.sv"  range:{start:{line:63  column:101}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}