Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workaround for incorrect null dereference warnings in GCC 11.1.0 #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TobiasFaller
Copy link

@TobiasFaller TobiasFaller commented Jul 1, 2021

This pull request provides a workaround for the fatal build error described in pulp-platform/pulp-sdk#102 by decreasing the severity of the warning.

@bluewww
Copy link

bluewww commented Jul 4, 2021

Actually I think we can just add this flag by default. No need to gate it behind this flag

@TobiasFaller
Copy link
Author

TobiasFaller commented Jul 4, 2021

@bluewww Changed workaround to be enabled by default. In this case the merge request pulp-platform/pulpissimo#263 can be reverted and I will close pulp-platform/pulp-sdk#103.

Copy link

@bluewww bluewww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TobiasFaller
Copy link
Author

@haugoug Will this fix be merged at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants