Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved dedicated AXI ID remappers into PULP cluster #263

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Moved dedicated AXI ID remappers into PULP cluster #263

merged 1 commit into from
Mar 25, 2024

Conversation

yvantor
Copy link
Contributor

@yvantor yvantor commented Mar 23, 2024 •
edited by alex96295
Loading

Fixes #249.

@yvantor yvantor requested a review from alex96295 as a code owner March 23, 2024 22:55
@yvantor
Copy link
Contributor Author

yvantor commented Mar 24, 2024

@alex96295 let me know

@alex96295 alex96295 changed the title Moved dedicated AXI ID remappers into PULP cluster. Moved dedicated AXI ID remappers into PULP cluster Mar 24, 2024
alex96295
alex96295 reviewed Mar 24, 2024
View reviewed changes
hw/cheshire_wrap.sv Outdated Show resolved Hide resolved
alex96295
alex96295 approved these changes Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@alex96295 alex96295 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor comment, other than that, LGTM

It simplifies the current 'hack' and makes the code more homogeneous; thanks for porting it to carfield :)

@yvantor
Copy link
Contributor Author

yvantor commented Mar 25, 2024

I left a minor comment, other than that, LGTM

It simplifies the current 'hack' and makes the code more homogeneous; thanks for porting it to carfield :)

Thank you bro, I committed the changes!

@alex96295
Copy link
Collaborator

I left a minor comment, other than that, LGTM
It simplifies the current 'hack' and makes the code more homogeneous; thanks for porting it to carfield :)

Thank you bro, I committed the changes!

Grazie, merging as soon as CI passes

@yvantor
Copy link
Contributor Author

yvantor commented Mar 25, 2024

I left a minor comment, other than that, LGTM
It simplifies the current 'hack' and makes the code more homogeneous; thanks for porting it to carfield :)

Thank you bro, I committed the changes!

Grazie, merging as soon as CI passes

Always the best!

@alex96295 alex96295 merged commit 405ace5 into main Mar 25, 2024
7 checks passed
@alex96295 alex96295 deleted the idw-conv branch March 25, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex96295 alex96295 alex96295 approved these changes

Assignees

@yvantor yvantor

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clip minimum number of external AXI masters to 1 due to PULP cluster limitations.
2 participants
@yvantor @alex96295