Add pulp-offload-intf.c to stimulate and test CVA6-PULP cluster interference
#255
Conversation
| @@ -61,9 +61,11 @@ CAR_ELFLOAD_BLOCKING_SAFED_SRC_C := $(CAR_SW_DIR)/tests/bare-metal/hostd/safed_o | |||
| CAR_ELFLOAD_BLOCKING_SAFED_PATH := $(basename $(CAR_ELFLOAD_BLOCKING_SAFED_SRC_C)) | |||
| CAR_ELFLOAD_PULPD_SRC_C := $(CAR_SW_DIR)/tests/bare-metal/hostd/pulp-offload.c | |||
| CAR_ELFLOAD_PULPD_PATH := $(basename $(CAR_ELFLOAD_PULPD_SRC_C)) | |||
| CAR_ELFLOAD_PULPD_INTF_SRC_C := $(CAR_SW_DIR)/tests/bare-metal/hostd/pulp-offload-intf.c | |||
| CAR_ELFLOAD_PULPD_INTF_PATH := $(basename $(CAR_ELFLOAD_PULPD_INTF_SRC_C)) | |||
There was a problem hiding this comment.
Do you think that doing:
CAR_ELFLOAD_PULPD_SRC_C += $(CAR_SW_DIR)/tests/bare-metal/hostd/pulp-offload-intf.c
Would work the same or might break? So we don't have to add dedicated variables for each new test we add (not sure it would work though).
There was a problem hiding this comment.
Ditto, we can append to the genric source variable CAR_ELFLOAD_PULPD_SRC_C
There was a problem hiding this comment.
I don't think it would work. CAR_ELFLOAD_PULPD_SRC_C (i.e. $(CAR_SW_DIR)/tests/bare-metal/hostd/pulp-offload.c) is used as an argument of offload_tests_template. We would need to add a second for loop there to check all the source files and execute the command $(CHS_SW_CC) $(CAR_SW_INCLUDES) $(CHS_SW_CCFLAGS) -c $(3) -o $(4).$(basename $(notdir $(header))).car.o; 2 times, with $(3) being pulp-offload.c and pulp-offload-intf.c in the second iteration. Without adding the for loop, we would pass two files with two main to the cc compiler and it would break.
There was a problem hiding this comment.
Yes, I agree. @alex96295 what do you think?
|
@luca-valente thanks for the addition of the test! I left few comments, mostly in line with what already commented by @yvantor If you have time to go through the review, that would be great! Otherwise, ping us and we can have a look :) |
alex96295
changed the title
pulp-offload-intf.c so that CVA6 interferes with the PULP cluster running applications (and viceversa).pulp-offload-intf.c to stimulate and test CVA6-PULP cluster interference
No description provided.