Cl/eth astral #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvantor
reviewed
Apr 18, 2024
| @@ -75,7 +75,7 @@ sources: | |||
| # package. Files in level 1 only depend on files in level 0, files in level 2 on files in | |||
| # levels 1 and 0, etc. Files within a level are ordered alphabetically. | |||
| # Level 0 | |||
| - hw/carfield_pkg.sv | |||
| - hw/carfield_pkg.sv | |||
| @@ -166,7 +166,7 @@ chs-sw-build: chs-sw-all | |||
|
|
|||
| .PHONY: car-sw-build | |||
| ## Builds carfield application SW and specific libraries. It links against `libcheshire.a`. | |||
| car-sw-build: chs-sw-build safed-sw-build pulpd-sw-build car-sw-all | |||
| car-sw-build: chs-sw-build pulpd-sw-build car-sw-all #safed-sw-build | |||
There was a problem hiding this comment.
Why commenting out the safed-sw-build?
| @@ -214,7 +214,7 @@ pulpd-sw-build: pulpd-sw-init | |||
| ## Initialize Carfield HW. This step takes care of the generation of the missing hardware or the | |||
| ## update of default HW configurations in some of the domains. See the two prerequisite's comment | |||
| ## for more information. | |||
| car-hw-init: spatzd-hw-init chs-hw-init secd-hw-init | |||
There was a problem hiding this comment.
Why removing the secd-hw-init?
| @@ -289,7 +289,7 @@ include $(CAR_SIM_DIR)/sim.mk | |||
|
|
|||
| .PHONY: car-init-all | |||
| ## Shortcut to initialize carfield with all the targets described above. | |||
| car-init-all: car-checkout car-hw-init car-sim-init safed-sw-init pulpd-sw-init mibench | |||
| car-init-all: car-checkout car-hw-init car-sim-init pulpd-sw-init mibench #safed-sw-init | |||
There was a problem hiding this comment.
Why commenting out the safed-sw-init?
Comment on lines
319
to
329
| localparam islands_cfg_t CarfieldIslandsCfg = '{ | ||
| l2_port0: '{L2Port0Enable, L2Port0Base, L2Port0Size}, | ||
| l2_port1: '{L2Port1Enable, L2Port1Base, L2Port1Size}, | ||
| safed: '{SafetyIslandEnable, SafetyIslandBase, SafetyIslandSize}, | ||
| l2_port0: '{0, L2Port0Base, L2Port0Size}, | ||
| l2_port1: '{0, L2Port1Base, L2Port1Size}, | ||
| safed: '{0, SafetyIslandBase, SafetyIslandSize}, | ||
| ethernet: '{EthernetEnable, EthernetBase, EthernetSize}, | ||
| periph: '{PeriphEnable, PeriphBase, PeriphSize}, | ||
| spatz: '{SpatzClusterEnable, SpatzClusterBase, SpatzClusterSize}, | ||
| spatz: '{0, SpatzClusterBase, SpatzClusterSize}, | ||
| pulp: '{PulpClusterEnable, PulpClusterBase, PulpClusterSize}, | ||
| secured: '{SecurityIslandEnable, SecurityIslandBase, SecurityIslandSize}, | ||
| secured: '{0, SecurityIslandBase, SecurityIslandSize}, | ||
| mbox: '{MailboxEnable, MailboxBase, MailboxSize} | ||
| }; |
There was a problem hiding this comment.
Create a specific config, add it to Bender.yml and use it in the bender-common.mk, do not just hammer it.
Comment on lines
+1
to
+2
| #include <stdio.h> | ||
| #include <stdlib.h> |
There was a problem hiding this comment.
You always have to add the copiright header on top of the files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethernet integration @yvantor