Swap division and department airtable columns (#827)

Closes #822
pulibrary · Jul 26, 2024 · de1dc43 · de1dc43
1 parent 3155652
commit de1dc43
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/app/models/air_table_staff/staff_directory_mapping.rb b/app/models/air_table_staff/staff_directory_mapping.rb
@@ -22,8 +22,8 @@ def fields
  { airtable_field: :Email, airtable_field_id: :fldbnDHHhDNlc2Lx8, our_field: :email },
  { airtable_field: :Address, airtable_field_id: :fldKZxmtofNbXW4qS, our_field: :address },
  { airtable_field: :'pul:Building', airtable_field_id: :fldz6yBenvTjdClXZ, our_field: :building },
- { airtable_field: :Division, airtable_field_id: :fldxpCzkJmhEkVqZt, our_field: :department },
- { airtable_field: :'pul:Department', airtable_field_id: :fld9NYFQePrPxbJJW, our_field: :division },
+ { airtable_field: :'pul:Department', airtable_field_id: :fld9NYFQePrPxbJJW, our_field: :department },
+ { airtable_field: :Division, airtable_field_id: :fldxpCzkJmhEkVqZt, our_field: :division },
  { airtable_field: :'pul:Unit', airtable_field_id: :fldusiuPpfSql6vSk, our_field: :unit },
  { airtable_field: :'pul:Team', airtable_field_id: :fldGzh0SHZqlFk3aU, our_field: :team },
  { airtable_field: :Title, airtable_field_id: :fldw0mjDdB48HstnB, our_field: :title },

diff --git a/spec/fixtures/files/air_table/records_no_offset.json b/spec/fixtures/files/air_table/records_no_offset.json
@@ -6,7 +6,8 @@
  "fields": {
  "fldKZxmtofNbXW4qS": "123 Stokes",
  "fldCCTbVNKKBFXxrp": ["Virtual Reality"],
- "fldxpCzkJmhEkVqZt": "Stokes",
+ "fldxpCzkJmhEkVqZt": "Special and Distinctive Collections",
+ "fld9NYFQePrPxbJJW": "Special Collections",
  "fldz6yBenvTjdClXZ": "Stokes",
  "fldcGj6p3JRzHzmZ8": "Librarian",
  "fldnKprqGraSvNTJK": "Phillip",

diff --git a/spec/models/air_table_staff/csv_builder_spec.rb b/spec/models/air_table_staff/csv_builder_spec.rb
@@ -11,7 +11,7 @@
  # as a single cell within a single row"
  expected = <<~END_CSV
  puid,netid,phone,name,lastName,firstName,email,address,building,department,division,unit,team,title,areasOfStudy,websiteUrl,bios,expertise,mySchedulerLink,otherEntities
- 123,ab123,(123) 123-1234,Phillip Librarian,Librarian,Phillip,[email protected],123 Stokes,Stokes,Stokes,,,,Library Collections Specialist V,Virtual Reality,,"Hello
+ 123,ab123,(123) 123-1234,Phillip Librarian,Librarian,Phillip,[email protected],123 Stokes,Stokes,Special Collections,Special and Distinctive Collections,,,Library Collections Specialist V,Virtual Reality,,"Hello
  My research interests
  are
 

diff --git a/spec/models/air_table_staff/staff_directory_person_spec.rb b/spec/models/air_table_staff/staff_directory_person_spec.rb
@@ -37,8 +37,8 @@
  '[email protected]', # email
  '123 Lewis Library', # address
  'Stokes Library', # building
- 'ReCAP', # department
- 'Cataloging and Metadata Services', # division
+ 'Cataloging and Metadata Services', # department
+ 'ReCAP', # division
  'Rare Books Cataloging Team', # unit
  'IT, Discovery and Access Services', # team
  'Library Software Engineer', # title

diff --git a/spec/models/air_table_staff/staff_list_job_spec.rb b/spec/models/air_table_staff/staff_list_job_spec.rb
@@ -16,7 +16,7 @@
  let(:first_row) do
  [
  '123', 'ab123', '(123) 123-1234', 'Phillip Librarian', 'Librarian', 'Phillip', '[email protected]',
- '123 Stokes', 'Stokes', 'Stokes', nil, nil, nil, 'Library Collections Specialist V', 'Virtual Reality',
+ '123 Stokes', 'Stokes', 'Special Collections', 'Special and Distinctive Collections', nil, nil, 'Library Collections Specialist V', 'Virtual Reality',
  nil, "Hello\nMy research interests\nare\n\nfantastic!", nil, 'https://example.com', 'Industrial Relations//James Madison Program'
  ]
  end