Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll for updates #90

Merged
merged 25 commits into from
Sep 24, 2024
Merged

Poll for updates #90

merged 25 commits into from
Sep 24, 2024

Conversation

tpendragon
Copy link
Contributor

@tpendragon tpendragon commented Sep 18, 2024 •
edited by hackartisan
Loading

closes #91

tpendragon and others added 6 commits September 18, 2024 14:55
@tpendragon
Add polling to Transformation.
0eacea5
@tpendragon
Demonstrate race condition.
83e661c
@sdellis @tpendragon @eliotjordan
Moved writing to hydration cache into the batch function
043cf8c 
Co-authored-by: Trey Pendragon <[email protected]>
Co-authored-by: Eliot Jordan <[email protected]>
Co-authored-by: Anna Headley <[email protected]>
@hackartisan @eliotjordan
@sdellis @tpendragon
it's broken though
4b9d8b1 
Co-authored-by: Eliot Jordan <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@eliotjordan @tpendragon
Debugging
3c19ff8 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@tpendragon
Use cache_order!
4d3e054
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Container Scanning Status: ✅ Success


ghcr.io/pulibrary/dpul-collections:pr-90 (debian 12.6)
======================================================
Total: 0 (HIGH: 0, CRITICAL: 0)

tpendragon and others added 15 commits September 18, 2024 17:28
@tpendragon
Fix Hydrator/Transformer Test
4b34973
@tpendragon
Fix other tests.
d0208be
@tpendragon
Get everything passing.
e7bb413
@tpendragon
Don't need Solr.commit
46d38e7
@tpendragon
Format.
751cc60
@tpendragon
Fix unit tests.
c2862fa
@tpendragon
Improve coverage some.
3b48612
@sdellis @eliotjordan
@hackartisan @tpendragon
Fixed bug with handle_info
239423c 
Co-authored-by: Eliot Jordan <[email protected]>
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@hackartisan @eliotjordan
@sdellis @tpendragon
Make transformation producer stop more gracefully
df86501 
Co-authored-by: Eliot Jordan <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@tpendragon @hackartisan
@eliotjordan @sdellis
Add trap_exit to indexing producer.
849f5e3 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Eliot Jordan <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
@eliotjordan
Start work on indexing integration tests
1ddef92 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@sdellis @hackartisan
@eliotjordan @tpendragon
Added find_by_id Solr helper and updated test for indexing integration
ff44788 
test

Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Eliot Jordan <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@hackartisan @eliotjordan
@sdellis @tpendragon
Finish indexing integration test
93c9682 
Co-authored-by: Eliot Jordan <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@hackartisan @eliotjordan
@sdellis @tpendragon
Remove unneeded exit handling
0daa364 
It wasn't actually getting used; trap exit just makes things shutdown
nicer all by itself

Co-authored-by: Eliot Jordan <[email protected]>
Co-authored-by: Shaun Ellis <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
@tpendragon
Finish coverage.
dcb3457
@tpendragon tpendragon marked this pull request as ready for review September 20, 2024 00:21
@sdellis @hackartisan
@eliotjordan @tpendragon
Clarified hydration upsert test
be896c3 
Co-authored-by: Anna Headley <[email protected]>
Co-authored-by: Eliot Jordan <[email protected]>
Co-authored-by: Trey Pendragon <[email protected]>
sdellis
sdellis approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@sdellis sdellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tpendragon tpendragon merged commit 6ea969d into main Sep 24, 2024
4 checks passed
@tpendragon tpendragon deleted the 45-indexing-timer branch September 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackartisan hackartisan hackartisan left review comments

@sdellis sdellis sdellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hydration, translation, and indexing should run simultaneously
4 participants
@tpendragon @sdellis @hackartisan @eliotjordan