Exception handling

pukei · Mar 25, 2015 · b9512c9 · b9512c9
1 parent 3fe482d
commit b9512c9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/lib/scorm_rte.rb b/lib/scorm_rte.rb
@@ -1,4 +1,5 @@
 require 'scorm_rte/engine'
+require 'scorm_rte/errors'
 require 'scorm_rte/lms/sco'
 require 'scorm_rte/lms/controllers/helpers'
 

diff --git a/lib/scorm_rte/errors.rb b/lib/scorm_rte/errors.rb
@@ -6,5 +6,8 @@ class ScormRteError < StandardError
   end
 
   class NoScoInstanceIdError < ScormRteError
+    def message
+      'Always provide a unique SCO intance ID'
+    end
   end
 end
diff --git a/lib/scorm_rte/lms/sco.rb b/lib/scorm_rte/lms/sco.rb
@@ -2,8 +2,8 @@ module ScormRte
   module Lms
     class Sco
       def initialize(sco_instance_id: nil)
-        unless sco_instance_id
-          fail NoScoInstanceIdError, 'Always provide a unique SCO intance ID'
+        unless sco_instance_id.present?
+          fail NoScoInstanceIdError
         end
         @sco_instance_id = sco_instance_id
       end