Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15 the library cant be installed on composer based sites where vendor folder is not public #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andergmartins
Copy link
Contributor

No description provided.

@htmgarcia
Copy link
Contributor

@andergmartins may I have guidelines to reproduce an scenario when vendor folder is not public?

@andergmartins
Copy link
Contributor Author

andergmartins commented Aug 26, 2022

Hey guys, @htmgarcia @agapetry @stevejburge @olatechpro @ojopaul I just realized the proposed solution might not work for WP VIP clients, unfortunately. The solution relies functions that write to files in the disk, so it is able to cache the requested files.
But when I submit the code to WP VIP scan, I get errors saying that is forbidden on their servers:

image

I'm afraid we might need another direction, sorry. I will think a little more about this next week.

Btw, this is a PR for just this library, but it is a guinea-pig for the other libraries we have and for the Free and Pro plugins... so it is an important decision we might take soon.

@andergmartins
Copy link
Contributor Author

Maybe that can be fixed using WP's filesystem API https://codex.wordpress.org/Filesystem_API, or reading and returning the asset's content on every request, making sure it can be cached by the browser instead of on server level.

@andergmartins
Copy link
Contributor Author

@andergmartins may I have guidelines to reproduce an scenario when vendor folder is not public?

@htmgarcia sorry, I didn't reply this. You could try using this https://roots.io/bedrock/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The library can't be installed on Composer based sites where vendor folder is not public
2 participants