fixes linting errors #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythongiant
reviewed
Dec 12, 2019
There was a problem hiding this comment.
Hi @ovpv you have merge conflicts in your PR. check them out? rest LGTM
Hey @pythongiant , I have resolved the conflicts. Please check and let me know if there are any further issues. |
|
hey @pythongiant , After the latest pull from the main branch, The build checks are failing. I am not sure why that's happening? can you help? |
|
Looks like checks are passing now, Good work |
pythongiant
approved these changes
Dec 22, 2019
hey @pythongiant , Does this usually take this much time to merge a PR in this repository or is it on hold due to some issue? if so please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewersor the user who published the issue for help, in a comment belowPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!