Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fix for empty search string #1646

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

kunmi02
Copy link
Contributor

@kunmi02 kunmi02 commented Apr 13, 2022

Fixes #1635 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Apr 13, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Apr 13, 2022

@codeclimate
Copy link

codeclimate bot commented Apr 13, 2022

Code Climate has analyzed commit 1e8534e and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1646 (36c1670) into main (4331ef0) will decrease coverage by 1.44%.
The diff coverage is 59.58%.

❗ Current head 36c1670 differs from pull request most recent head 1e8534e. Consider uploading reports for the commit 1e8534e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
- Coverage   72.98%   71.54%   -1.45%     
==========================================
  Files          40       40              
  Lines        1399     1409      +10     
==========================================
- Hits         1021     1008      -13     
- Misses        378      401      +23     
Impacted Files Coverage Δ
app/channels/concurrent_editing_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/controllers/utility_controller.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/users_helper.rb 21.73% <0.00%> (ø)
app/models/map.rb 92.25% <ø> (-1.30%) ⬇️
app/helpers/application_helper.rb 50.00% <20.00%> (ø)
app/controllers/annotations_controller.rb 59.25% <22.22%> (ø)
app/controllers/sessions_controller.rb 32.91% <22.22%> (ø)
app/controllers/front_ui_controller.rb 74.28% <33.33%> (ø)
app/controllers/application_controller.rb 88.88% <50.00%> (ø)
app/controllers/images_controller.rb 76.54% <61.90%> (ø)
... and 15 more

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🎉 Thanks for fixing this @kunmi02

@cesswairimu
Copy link
Collaborator

The same error appears if one inputs less than 3 chars, it could be a follow up issue if you would like to work on it. Thanks again, merging now

@cesswairimu cesswairimu merged commit 358a281 into publiclab:main Apr 14, 2022
@welcome
Copy link

welcome bot commented Apr 14, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@kunmi02
Copy link
Contributor Author

kunmi02 commented Apr 15, 2022

@cesswairimu Thanks for notifying me about the search character less than 3. I created an issue for it here #1650 . I have a corresponding PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Empty search string on page
2 participants