Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v3.6.0 for new npm release #1695

Merged
merged 6 commits into from
Oct 18, 2020
Merged

Bump to v3.6.0 for new npm release #1695

merged 6 commits into from
Oct 18, 2020

Conversation

jywarren
Copy link
Member

This accounts for a TON of changes over the past 13 months. Compiling some highlights:

I am surely missing a ton here. But much appreciation to the following contributors during this period:

@keshav234156 @blurry-x-face @aashna27 @harshkhandeparkar @root00198 @ataata107 @tech4GT @anthony-zhou @Divy123 @VladimirMikulic @Ryan10145 @tsparksh @yottabytedev @vgadodia @vaibhavmatta @tudoranghelina91 @sanjana091001 @samagragupta @pythongiant @ovsundal @ojurkiewicz @nisarhassan12 @niravasher @kirito-k @johanuribe03 @ikayz @freerangeandy @duyquangnguyenhac @dnhuan @arghac14 @Olusamimaths @Deogle @28-ys @sashadev-sky @bhavayAnand9

Please feel free to chime in with big updates to be added to the changelog if you like! 🎉

And, try out our new GitPod integration allowing us to more quickly and effectively review PRs due to on-the-fly interactive builds for each PR pushed up.

@gitpod-io
Copy link

gitpod-io bot commented Jul 12, 2020

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #1695 into main will increase coverage by 10.31%.
The diff coverage is 64.31%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1695       +/-   ##
===========================================
+ Coverage   55.11%   65.43%   +10.31%     
===========================================
  Files         117      133       +16     
  Lines        2344     2743      +399     
  Branches      360      439       +79     
===========================================
+ Hits         1292     1795      +503     
+ Misses       1052      948      -104     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) ⬇️
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) ⬇️
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) ⬆️
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) ⬇️
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 102 more

@jywarren jywarren mentioned this pull request Jul 12, 2020
@harshkhandeparkar
Copy link
Member

Cool. Let's release it! Pushing to beta.

@harshkhandeparkar
Copy link
Member

Has it been 13 months? Wow! We need to publish sooner...

@jywarren
Copy link
Member Author

jywarren commented Jul 12, 2020

@harshkhandeparkar yes we do! This Gitpod thing plus all the fantastic UI testing we have will make this easier -- #1000, more specifics here: #1369. I'd like to call for more UI testing to be implemented, to further secure our base feature set, as well as ask for any help with the #1694.

@harshkhandeparkar
Copy link
Member

Can you wait before my latest PR gets merged?

@jywarren
Copy link
Member Author

Before releasing this one? Sure, which PR?

@jywarren
Copy link
Member Author

I'd also like to try to set a new requirement that any new feature has:

  1. a good test demonstrating its use and guaranteeing it against future breakage
  2. a line in the README describing the function and how to use it.

That'll help us stabilize things a lot from here out!

@harshkhandeparkar
Copy link
Member

#1696, part of bug stomp feb, yet I opened the PR in July 😂

@jywarren
Copy link
Member Author

jywarren commented Aug 5, 2020

@harshkhandeparkar why don't we just release v3.6.0 and you can have more time to finish the test fixes for edge detection, and we'll just immediately release v3.6.1. We should be releasing more often anyways!

@jywarren
Copy link
Member Author

Hmm. only 4603.8 jest-puppeteer UI tests (full browser env) failed.

@jywarren
Copy link
Member Author

jywarren commented Aug 11, 2020

Looks like a timeout when fetching deps. Restarted. (Fixed!)

@harshkhandeparkar
Copy link
Member

@harshkhandeparkar why don't we just release v3.6.0 and you can have more time to finish the test fixes for edge detection, and we'll just immediately release v3.6.1. We should be releasing more often anyways!

Sure. I forgot to add the tests actually 😅

@jywarren
Copy link
Member Author

OK, let's do this!!! Releasing as v3.6.0 and we'll do this more often now!

@jywarren
Copy link
Member Author

Wait, i need to coordinate building this and the new script at #1703... hang on...

@harshkhandeparkar harshkhandeparkar requested a review from a team as a code owner October 15, 2020 20:01
@harshkhandeparkar
Copy link
Member

@jywarren Do you mind if I make a tag along with the changelog in the releases page for this? I will also push to the stable branch.

I have an idea for how to do the npm packages which I will mention in #1692

@harshkhandeparkar
Copy link
Member

@jywarren check out the new project I opened.

@jywarren
Copy link
Member Author

@jywarren Do you mind if I make a tag along with the changelog in the releases page for this? I will also push to the stable branch.

Sure, ok! You mean after this is merged. What other PRs should we try to merge before this, or should we just go ahead with 3.6.0 and do others in a follow-up?

@harshkhandeparkar
Copy link
Member

This is ready for merge unless @publiclab/is-maintainers want some other PR/issue to be fixed (in which case, add it to the v3.6.0 project) :)

@jywarren
Copy link
Member Author

Agreed, I merged or approved a couple dependabot prs so we can merge this after!

@jywarren
Copy link
Member Author

OK, running final update!

@jywarren jywarren merged commit a2d6543 into main Oct 18, 2020
@jywarren
Copy link
Member Author

Merged! Let's publish v3.6.0! @harshkhandeparkar what is our checklist, can we organize the checklist here?

  • finalize and merge to main branch
  • build and publish /dist/ files (should this be part of the PR that finalizes the bump, i.e. should we have done that here @harshkhandeparkar et al?)
  • merge to stable
  • create a release on GitHub and use features description from (this) release PR to add release notes
  • tag version number
  • publish to npm
  • publish to live github-pages demo (with github action to publish demo at sequencer.publiclab.org #1703 eventually)

How does this look?

@harshkhandeparkar
Copy link
Member

Umm, we don't add dist files to the main branch anymore. I will do the pushing to stable and the release notes :) It is 2AM here so may I do it tomorrow?

@harshkhandeparkar
Copy link
Member

Also, the team discussions are turned off, is that intentional? If not, we can make these checklists there ig...

@jywarren
Copy link
Member Author

Also, the team discussions are turned off, is that intentional? If not, we can make these checklists there ig...

Yes, i've found it's quite hard to find the team discussions as they don't work the same way as issues. I prefer to use issues for all discussions, which i feel is more transparent, sound good? Thanks Harsh!

The steps i noted prob need to be reordered and corrected -- can you edit my comment or copy it? I think we should keep a standard checklist for each release!

@jywarren
Copy link
Member Author

Maybe we can do a template, which we use to run the release process from within. It seems GitHub doesn't do multiple pull requests templates, but we could run the release within an issue using an issue template, and that makes sense anyways because there are steps /after/ merging the pull request, so the issue would stay open until the very end of the checklist.

How does that sound?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants