Add method to reorder steps in sequencer object

[rishabhshuklax]

Fixes #1621

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[codecov]

Codecov Report

Merging #1626 into main will increase coverage by 10.11%.
The diff coverage is 63.23%.

@@             Coverage Diff             @@
##             main    #1626       +/-   ##
===========================================
+ Coverage   55.11%   65.23%   +10.11%     
===========================================
  Files         117      132       +15     
  Lines        2344     2750      +406     
  Branches      360      439       +79     
===========================================
+ Hits         1292     1794      +502     
+ Misses       1052      956       -96     

Impacted Files	Coverage Δ
examples/lib/scopeQuery.js	18.51% <ø> (ø)
src/Modules.js	100.00% <ø> (ø)
src/modules/WebglDistort/Module.js	2.29% <0.00%> (ø)
src/ui/SetInputStep.js	12.90% <0.00%> (-1.39%)	⬇️
src/modules/ColorHalftone/Module.js	3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js	11.35% <4.08%> (-0.85%)	⬇️
examples/lib/intermediateHtmlStepUi.js	11.11% <5.55%> (+0.94%)	⬆️
examples/lib/insertPreview.js	13.15% <20.00%> (-0.36%)	⬇️
src/util/getImageDimensions.js	20.00% <20.00%> (ø)
src/util/isGif.js	20.00% <20.00%> (ø)
... and 100 more

[harshkhandeparkar]

I think the old code has non-descriptive variables and is, well, old. Can we at least make the new additions better if not change the old code?

[rishabhshuklax]

I think the old code has non-descriptive variables and is, well, old. Can we at least make the new additions better if not change the old code?

I think we should make a seperate issue to change these names in a single PR as changing the names on the newer code will make it inconsistent.

[gitpod-io]

[harshkhandeparkar]

I meant this btw, can these be named something better?

[rishabhshuklax]

Are that's what I said in the file these names are used in the other functions as well so it'd be better to change it all together so as to avoid any inconsistency.

image-sequencer/src/ImageSequencer.js

Lines 127 to 131 in fa96a7a

	var args = [];
	for (var arg in arguments) args.push(copy(arguments[arg]));
	var json_q = formatInput.call(this_, args, '-');
	inputlog.push({ method: 'removeSteps', json_q: copy(json_q) });

[harshkhandeparkar]

So you basically don't know what they even mean? 😂

[harshkhandeparkar]

It's fine. APPROVED lol.

[jywarren]

Hey lets be nice here! I am probably guilty of the ambiguous naming after all :-) so I can take the blame.

I agree though that let's change it in a consistent manner so as not to confuse folks. And if there are any opportunities to reduce repetitive code, that's great too!

[harshkhandeparkar]

Oh sorry. I was just joking anyway, you are lucky that I didn't build sequencer's backend 😂

[jywarren]

This is a cool one! I'd like to request:

1. a good test demonstrating its use and guaranteeing it against future breakage
2. a line in the README describing the function and how to use it.

Thank you!!!! No rush, just looking for what we should start requiring for all changes moving forward!