Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Overlay module for gifs #1616

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ataata107
Copy link

@ataata107 ataata107 commented Feb 5, 2020

Concerns #1468 (<=== Replace 0000 with the Issue Number)
ezgif com-video-to-gif (1)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@ataata107
Copy link
Author

@publiclab/is-reviewers overlay is working now

@harshkhandeparkar harshkhandeparkar added work-in-progress almost-complete PRs that are almost done but little more work. and removed work-in-progress labels Jul 7, 2020
@harshkhandeparkar
Copy link
Member

@ataata107 if you are still working on this, can you please fix the error?

@govindgoel
Copy link
Member

@ataata107 Any updates on this?

@grvsachdeva
Copy link
Member

Hi @govindgoel @harshkhandeparkar, as @ataata107 not active anymore. You can fix the issue in this PR if you're interested or we can close this PR. Thank you @ataata107 for taking dig at the issue :)

Thanks!

@harshkhandeparkar harshkhandeparkar marked this pull request as draft July 27, 2021 21:15
@harshkhandeparkar harshkhandeparkar removed the almost-complete PRs that are almost done but little more work. label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants