fixes: #575 links to change selected Repo #578
Conversation
on2onyekachi
force-pushed
the
fix_link_for_all
branch
from
aae0e08
to
e262b8d
Compare
|
@on2onyekachi When I tried it locally, it redirected to another URL entirely. We want only the repo to change. Screen.Recording.2022-05-17.at.12.17.28.mov |
|
I see. I also did experience this while working locally. I guess that is a result of the hard-coded URL from the config.json file. I had to change the URL pointing to my local server URL to 127.0.0.1 before actually working on it. Maybe we could get a solution that should allow the use of absolute URLs/URIs that work locally in a local development environment and also work on the remote server without modification.? Thanks @TildaDares |
|
@on2onyekachi Let's take the easy route and leave only the changes in |
Okay, though that's like going back to the default behavior of both links. Maybe, is there a much better approach to this?. I also think due to the hash(#) symbol on the URL it can't possibly reload the page, hence the manual reloading of the page on the select repository dropdown buttons. @TildaDares, Just before I remove the other files, I will want to propose we take out that line in the configure.js file since we're only making use of it for this case only and work directly with the HTML href attribute. |
|
here is how it is. ssr.mov |
|
@on2onyekachi Go for it!! |
|
Yeah!! Thanks, @TildaDares 🙂 |
|
@TildaDares Done. Please review. |
| $('.org-wide-issues').on('click', ()=>{ | ||
| location.href = $('.org-wide-issues').attr("href") | ||
| location.reload(); | ||
| }) |
There was a problem hiding this comment.
This works perfectly @on2onyekachi!! Can you just make sure that the indentation is two spaces deep? Thank you!!
There was a problem hiding this comment.
Thanks, @TildaDares No, I followed the indentation of the file, all 4spaces. Should I fix all of it, or make it an FTO?
There was a problem hiding this comment.
You know what let’s leave it that way so it doesn’t look odd.
|
Can I just fix just that? @TildaDares thanks. |
|
Thank you for this @on2onyekachi!!! |
fixes: #575
Before:
Screen.Recording.2022-05-13.at.07.45.21.mov
After:
Screen.Recording.2022-05-16.at.18.40.31.mov
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!