Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/standalone tests #249

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Refactor/standalone tests #249

wants to merge 2 commits into from

Conversation

amirRamirfatahi
Copy link
Collaborator

@amirRamirfatahi amirRamirfatahi commented Dec 12, 2024 •
edited
Loading

#172

Pre-submission Checklist

For tests to work you need a working neo4j and redis instance with the example dataset in docker/db-graph

  • Testing: Implement and pass new tests for the new features/fixes, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

SHAcollision
SHAcollision reviewed Dec 12, 2024
View reviewed changes
tests/service/stream/post/author_replies.rs
@@ -2,7 +2,7 @@ use super::ROOT_PATH;
use crate::service::utils::make_request;
use anyhow::Result;

#[tokio::test]
#[tokio_shared_rt::test(shared)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the benefits for service tests of using the shared tokio runtime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SHAcollision SHAcollision SHAcollision left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amirRamirfatahi @SHAcollision