feat: make ClosestNodes public

Cargo.toml

@@ -38,9 +38,6 @@ dashmap = "6.1"
 ## Enable [Dht::as_async()] to use [async_dht::AsyncDht]
 async = ["flume/async"]
 
-## Private feature to export ClosestNodes struct. Not a public API.
-__private_simulation = []
-
 default = []
 
 [package.metadata.docs.rs]

docs/simulation/Cargo.toml

@@ -6,7 +6,7 @@ edition = "2021"
 [dependencies]
 clap = { version = "4.5.20", features = ["derive"] }
 ctrlc = "3.4.5"
-mainline = { version = "3.0.1", path = "../..", features = ["__private_simulation"] }
+mainline = { version = "3.0.1", path = "../.." }
 num_cpus = "1.16.0"
 plotters = "0.3.7"
 statrs = "0.17.1"

src/common/node.rs

@@ -64,7 +64,6 @@ impl Node {
         }
     }
 
-    #[cfg(any(test, feature = "__private_simulation"))]
     /// Create a node that is unique per `i` as it has a random Id and sets IP and port to `i`
     pub fn unique(i: usize) -> Node {
         use std::net::Ipv4Addr;

src/lib.rs

@@ -15,6 +15,7 @@ pub mod server;
 
 pub use crate::common::{Id, MutableItem, Node};
 pub use dht::{Dht, Settings, Testnet};
+pub use rpc::ClosestNodes;
 
 pub use bytes::Bytes;
 pub use ed25519_dalek::SigningKey;
@@ -23,6 +24,3 @@ pub mod errors {
     //! Exported errors
     pub use super::rpc::PutError;
 }
-
-#[cfg(feature = "__private_simulation")]
-pub use rpc::ClosestNodes;

src/rpc/closest_nodes.rs

@@ -62,7 +62,7 @@ impl ClosestNodes {
     }
 
     /// Take enough nodes closest to the target, until the following are satisfied:
-    /// 1. At least the closest [k][MAX_BUCKET_SIZE_K].
+    /// 1. At least the closest `k` nodes (20).
     /// 2. The last node should be at a distance `edk` which is the expected distance of the 20th
     ///    node given previous estimations of the DHT size.
     /// 3. The number of subnets with uniqu e6 bits prefix in nodes ipv4 addresses match or exceeds