-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update organization of the unit tests #18
Conversation
Hi @colltoaction and @FraLotito --- would really appreciate your thoughts on these changes! I reorganized the unit tests to make them easier to contribute to. |
Thanks @nwlandry! I'll check it out in the following days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we can remove some duplication like return json.load...
but I don't see any pytest feature to aid with this.
WRT formatting it would be good to understand what this formatter is doing but it's fine with me. An external formatter / linter could be ran in Actions for guardrailing.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I agree with this structure, I think the changes improve the readability and organization of the tests. Thanks @nwlandry !
Good point! I'll see what's out there. |
@FraLotito and @colltoaction, thanks for reviewing!! |
This PR does the following:
conftest.py
and the unit test files roughly in these categories: top-level attributes, metadata, nodes, edges, and incidences.