Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new example 2 Ions #8

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

psychocoderHPC
Copy link
Owner

2D preview C2H6

use submit/0016gpus.cfg -> for 2D simulation

@psychocoderHPC psychocoderHPC force-pushed the topic-gasFunctorsMultiSpecies-rb3-example branch 4 times, most recently from 981de19 to a03fcf9 Compare June 4, 2015 12:50
@psychocoderHPC psychocoderHPC force-pushed the topic-gasFunctorsMultiSpecies-rb3-example branch from a03fcf9 to 6b416e9 Compare June 4, 2015 13:04
@@ -120,41 +128,51 @@ typedef Particles<ParticleDescription<
struct Hydrogen
{
static const float_X numberOfProtons = 1.0;
static const float_X numberOfNeutrons = 0.0;
static const float_X numberOfNeutrons = 1.0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be Deuterium
I think you wanted a hydrogen gas molecule, having 2 protons and no neutron.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's intended. deuterium has the same charge/mass ratio as carbon, helium, oxygen, ... in their natural isotopes. protons not. but one would call this 'D' not 'H'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure but why not just add a struct Deuterium?
At some point we need a list of the most common elements anyway.
@psychocoderHPC you can also create a new file for only the structs of these elements.
Anyway IMO you should create a new struct and give it a suitable name.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are commenting on an outdated, offline example for me. don't worry ;)

psychocoderHPC pushed a commit that referenced this pull request Jul 30, 2015
ad799c9 Merge pull request #9 from ComputationalRadiationPhysics/topic-mallocVersionCleanup
9299042 mallocMC: Unset Temp Vars (Version)
3a65fa4 Merge pull request #8 from ComputationalRadiationPhysics/topic-mallocPreferHints
b481ca0 CMake: FOUND_VAR & CUDA_SEPARABLE_COMPILATION
70b94e6 Fix Cache Weirdness (Last Commit)
e4f0d5b Fix CACHE Scopes and Clean Ups
a118419 Find mallocMC: Prefer Hints over Default Paths

git-subtree-dir: thirdParty/cmake-modules
git-subtree-split: ad799c9b3e5c1146ef005afb69c5a88216476a83
psychocoderHPC pushed a commit that referenced this pull request Nov 7, 2017
8a0e21bea Merge pull request #13 from ComputationalRadiationPhysics/topic-wextra
65b082e27 Fix Unused Parameter Warning
5888a7a63 Travis: Werror
34d6e74bc Merge pull request #12 from psychocoderHPC/fix-warningUnusedReturnValue
9d49d4a6d fix warning `result of call is not use`
c9fa12e90 Merge pull request #8 from ComputationalRadiationPhysics/topic-cincludes
62e29c061 Includes: C includes in C++

git-subtree-dir: thirdParty/cuda_memtest
git-subtree-split: 8a0e21bea7be98a1d0f0f9fc48ae90f87c3ecb81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants