Fix Zammad plugin by filtering tickets after search #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
psss
requested changes
Oct 2, 2023
| except urllib.error.URLError as error: | ||
| log.debug(error) | ||
| raise ReportError( | ||
| "Zammad search on {0} failed.".format(self.url)) |
There was a problem hiding this comment.
This part seems to be copy & pasted from the search() method. What about separating the common code to prevent duplication? There could be a common search() method used by both get_articles() and get_tickets(). What do you think, @come-nc?
| for _,ticket in self.parent.zammad.search(query).items(): | ||
| for article in self.parent.zammad.get_articles(ticket["id"]): | ||
| updated_at = datetime.fromisoformat(article["updated_at"].replace('Z', '+00:00')).date() | ||
| if (article["created_by"] == self.user.email) and (updated_at >= self.options.since.date) and (updated_at <= self.options.until.date): |
There was a problem hiding this comment.
Please, wrap the long line to make pre-commit happy. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API query is not searching correctly and is returning more tickets that it should, so we loop on them and get articles from the API to filter which one were actually updated in the time range.
This reduces false positive a lot.