Add stb single header libraries #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkwouter
commented
Jul 14, 2024
diamant3
requested changes
Jul 14, 2024
stb/PSPBUILD
Outdated
| pkgdesc="a collection of single-file public domain libraries for C/C++" | ||
| arch=('mips') | ||
| url="https://github.com/nothings/stb" | ||
| license=('Public Domain' 'MIT') |
There was a problem hiding this comment.
You should use Public Domain OR MIT instead of splitting them into two.
ref: https://spdx.github.io/spdx-spec/v3.0/annexes/SPDX-license-expressions/ from https://wiki.archlinux.org/title/PKGBUILD#license
There was a problem hiding this comment.
Oh, I wasn't aware. Thanks! I'll change it.
|
Although, the packaging guide says you must always set the arch to "mips", this should only be true for packages containing native code. If the package only contains headers, scripts, makefiles, documentation, configs, etc., then arch should be set to "any". Not that it matters much anyway in the case of PSP. Also applicable to glm. |
|
@tpimh that's fair. Will change it. |
|
Looks good now, Thanks for working on this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some useful single header libraries that are public domain, so they can be used without attribution.