Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypyc build improvements #3881

Merged
merged 2 commits into from
Sep 11, 2023
Merged

mypyc build improvements #3881

merged 2 commits into from
Sep 11, 2023

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Sep 11, 2023 •
edited
Loading

  • Build in separate jobs. This makes it clearer if e.g. a single Python version is failing. It also potentially gets you more parallelism.
  • Build everything on push to master.
  • Only build Linux 3.8 and 3.11 wheels on PRs.

Fixes #3879

@hauntsaninja hauntsaninja added the skip news Pull requests that don't need a changelog entry. label Sep 11, 2023
@hauntsaninja hauntsaninja force-pushed the wheel-build branch 3 times, most recently from 17dd648 to 7c502fa Compare September 11, 2023 05:09
@hauntsaninja
mypyc build improvements
81e2b57 
Build in separate jobs. This makes it clearer if e.g. a single Python
version is failing. It also potentially gets you more parallelism.

Build everything on push to master.

Only build Linux 3.8 and 3.11 wheels on PRs.
@github-actions
Copy link

github-actions bot commented Sep 11, 2023 •
edited
Loading

diff-shades reports zero changes comparing this PR (beda040) to main (e73662c).

What is this? | Workflow run | diff-shades documentation

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Sep 11, 2023 •
edited
Loading

Oh we also now don't build universal wheels on macOS. No one uses these because we build single arch wheels; we dropped them in mypy a while ago and never looked back.

@hauntsaninja hauntsaninja merged commit 004fb79 into psf:main Sep 11, 2023
34 checks passed
@hauntsaninja hauntsaninja deleted the wheel-build branch September 11, 2023 20:36
@hauntsaninja hauntsaninja mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run wheel build on fewer PRs?
2 participants
@hauntsaninja @JelleZijlstra