-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Eloquent Model alias at ApplicationProvider #273
base: master
Are you sure you want to change the base?
Conversation
@lptn The failed tests are my bad? |
I don't think so. Codeception tests failed due to Psalm changes (a new output), Laravel projects tests failed due to a flag to find unused code. I'll try to fix both tomorrow (if there are no other volunteers), but it will be nice to add tests for your changes. |
I don't know how codeception works 😥 |
Thanks for the PR! 🤝 This seems reasonable to me. However, I did just think of a slight edge case. Consider that I really think this should be fixed upstream in ide-helper, but I think I'm okay with merging this as-is for now. |
Hey @eusonlito Is this PR related to the issue barryvdh/laravel-ide-helper#1352 ? |
Related with issue #271