Avoid endless loops when RPC binding #693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip actions]
|
Please let's add some description to the PRs to understand better what's the PR about |
@fjtrujy done |
fjtrujy
reviewed
Dec 12, 2024
|
Seems like my branch was based on my master branch. That's why that change I there. It wasn't intentional. Will fix |
applications will no longer hang eternally on a loop. Applications that bind to RPC should check return values of rpc binding functions and throw errors if necesary to avoid the program to continue execution as if server is ok
|
I see lots of mess with merge upstream Could you squash and merge instead of normal merge @fjtrujy ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to avoid RPC binding to incompatible/non loaded IRX modules to result on an endless loop. By aborting the process after 100 failed binding attempts
Example:
A program built with libpadx tries to bind RPC while
rom0:PADMANis loaded would result on an endless loop.With this change, it will no longer hang