Make QUIC The Default Transport #14688
Merged
+42
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a good time to update quic-go to the latest. It has been a while since we updated it. |
nalepae
force-pushed
the
makeQUICDefault
branch
from
352fe60
to
6fb00f5
Compare
nalepae
force-pushed
the
makeQUICDefault
branch
from
e5c4063
to
fe88018
Compare
prestonvanloon
approved these changes
Dec 3, 2024
(Reviewed them as well!) |
|
Hey folks. Just making a note that this could be breaking someones setup if they used the |
skylenet
added a commit
to ethpandaops/ethereum-package
that referenced
this pull request
Dec 4, 2024
…he new quic port (#845) Prysm added QUIC to their client as per prysmaticlabs/prysm#14688 . This currently broke our runs using the master branch prysm image due to the QUIC port running on 13000 by default. Which was conflicting with the settings we were providing for the UDP port: ```sh --p2p-quic-port value The QUIC port used by libp2p. (default: 13000) --p2p-tcp-port value The TCP port used by libp2p. (default: 13000) --p2p-udp-port value The UDP port used by the discovery service discv5. (default: 12000) ``` I've also added the CLI flags for it, but still commented out until a stable release is done.
|
Thanks for bringing this up @skylenet, that is a good point. We will add this to our release notes to flag that this port will be taken up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This makes
QUICthe default transport protocol in prysm and will make every prysm node connect to other nodes via QUIC if supported.Which issues(s) does this PR fix?
N.A
Other notes for review
Acknowledgements