Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interop genesis service from beacon node #14417

Merged
merged 18 commits into from
Dec 3, 2024
Merged

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Sep 4, 2024

What type of PR is this?

Other

What does this PR do? Why is it needed?

The intention of this PR is to reduce unnecessary dependencies in the beacon node and reduce legacy tech debt. The features of --interop-genesis-time and --interop-num-validators can be replaced by generating the beacon state with external tooling and using it within the beacon node via --genesis-state=/path/to/genesis.ssz.

Caution

The devnet instructions are mostly incomplete, but should not block this PR.

Running a devnet

Example workflow prior to this PR:

# Setup an EL... <omitted>
# And then, start Prysm with a genesis time 30s into the future and 1024 validators. Other flags
omitted.
./beacon-chain \
  --interop-genesis-time=$(date -d "30 seconds" +%s) \
  --interop-num-validators=1024 \
 <other flags omitted>

The new workflow is an additional step, but common practice with devnets.

# Setup an EL... <omitted>
# And then, create the genesis.ssz with a start time 30s into the future.
./prysmctl testnet generate-genesis \
  --num-validators=1024 \
  --genesis-time-delay=30 \
  --output-ssz=/data/genesis.ssz

./beacon-chain \
  --genesis-state=/data/genesis.ssz \ # Use the generated genesis state.
  <other flags omitted>

Which issues(s) does this PR fix?

Other notes for review

Note: The interop functionality of the validator is unchanged for now. The flags --interop-num-validators and --interop-start-index remain in the validator client until a follow up PR.

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@prestonvanloon prestonvanloon marked this pull request as ready for review November 20, 2024 13:27
@prestonvanloon prestonvanloon requested a review from a team as a code owner November 20, 2024 13:27
terencechain
terencechain previously approved these changes Nov 20, 2024
terencechain
terencechain previously approved these changes Dec 3, 2024
@prestonvanloon prestonvanloon added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit ac72fe2 Dec 3, 2024
15 checks passed
@prestonvanloon prestonvanloon deleted the rm-interop branch December 3, 2024 19:16
@kasey kasey added changelog/removed Changelog Section: Removed changelog/deprecated Changelog Section: Deprecated and removed changelog/removed Changelog Section: Removed labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/deprecated Changelog Section: Deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants