Skip to content

Commit

Permalink
Remove the Goerli/Prater support. (#13846)
Browse files Browse the repository at this point in the history
  • Loading branch information
nalepae authored Apr 3, 2024
1 parent f7912e7 commit 8cf5d79
Show file tree
Hide file tree
Showing 22 changed files with 11 additions and 159 deletions.
16 changes: 0 additions & 16 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -342,22 +342,6 @@ filegroup(
url = "https://github.com/eth-clients/eth2-networks/archive/934c948e69205dcf2deb87e4ae6cc140c335f94d.tar.gz",
)

http_archive(
name = "goerli_testnet",
build_file_content = """
filegroup(
name = "configs",
srcs = [
"prater/config.yaml",
],
visibility = ["//visibility:public"],
)
""",
sha256 = "43fc0f55ddff7b511713e2de07aa22846a67432df997296fb4fc09cd8ed1dcdb",
strip_prefix = "goerli-6522ac6684693740cd4ddcc2a0662e03702aa4a1",
url = "https://github.com/eth-clients/goerli/archive/6522ac6684693740cd4ddcc2a0662e03702aa4a1.tar.gz",
)

http_archive(
name = "holesky_testnet",
build_file_content = """
Expand Down
6 changes: 3 additions & 3 deletions beacon-chain/node/node_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ func Test_hasNetworkFlag(t *testing.T) {
want bool
}{
{
name: "Prater testnet",
networkName: features.PraterTestnet.Name,
networkValue: "prater",
name: "Holesky testnet",
networkName: features.HoleskyTestnet.Name,
networkValue: "holesky",
want: true,
},
{
Expand Down
2 changes: 1 addition & 1 deletion cmd/prysmctl/testnet/generate_genesis.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ var (
},
&cli.StringFlag{
Name: "config-name",
Usage: "Config kind to be used for generating the genesis state. Default: mainnet. Options include mainnet, interop, minimal, prater, sepolia. --chain-config-file will override this flag.",
Usage: "Config kind to be used for generating the genesis state. Default: mainnet. Options include mainnet, interop, minimal, sepolia, holesky. --chain-config-file will override this flag.",
Destination: &generateGenesisStateFlags.ConfigName,
Value: params.MainnetName,
},
Expand Down
1 change: 0 additions & 1 deletion cmd/prysmctl/validator/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ var Commands = []*cli.Command{
flags.ForceExitFlag,
flags.VoluntaryExitJSONOutputPath,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
cmd.AcceptTosFlag,
Expand Down
5 changes: 0 additions & 5 deletions cmd/validator/accounts/accounts.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ var Commands = &cli.Command{
flags.WalletPasswordFileFlag,
flags.DeletePublicKeysFlag,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
cmd.AcceptTosFlag,
Expand Down Expand Up @@ -63,7 +62,6 @@ var Commands = &cli.Command{
flags.GrpcRetriesFlag,
flags.GrpcRetryDelayFlag,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
cmd.AcceptTosFlag,
Expand Down Expand Up @@ -97,7 +95,6 @@ var Commands = &cli.Command{
flags.BackupPublicKeysFlag,
flags.BackupPasswordFile,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
cmd.AcceptTosFlag,
Expand Down Expand Up @@ -128,7 +125,6 @@ var Commands = &cli.Command{
flags.AccountPasswordFileFlag,
flags.ImportPrivateKeyFileFlag,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
cmd.AcceptTosFlag,
Expand Down Expand Up @@ -171,7 +167,6 @@ var Commands = &cli.Command{
flags.ForceExitFlag,
flags.VoluntaryExitJSONOutputPath,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
cmd.AcceptTosFlag,
Expand Down
2 changes: 0 additions & 2 deletions cmd/validator/slashing-protection/slashing-protection.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ var Commands = &cli.Command{
cmd.DataDirFlag,
flags.SlashingProtectionExportDirFlag,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
features.EnableMinimalSlashingProtection,
Expand Down Expand Up @@ -51,7 +50,6 @@ var Commands = &cli.Command{
cmd.DataDirFlag,
flags.SlashingProtectionJSONFileFlag,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
features.EnableMinimalSlashingProtection,
Expand Down
2 changes: 0 additions & 2 deletions cmd/validator/wallet/wallet.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ var Commands = &cli.Command{
flags.Mnemonic25thWordFileFlag,
flags.SkipMnemonic25thWordCheckFlag,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
cmd.AcceptTosFlag,
Expand Down Expand Up @@ -63,7 +62,6 @@ var Commands = &cli.Command{
flags.Mnemonic25thWordFileFlag,
flags.SkipMnemonic25thWordCheckFlag,
features.Mainnet,
features.PraterTestnet,
features.SepoliaTestnet,
features.HoleskyTestnet,
cmd.AcceptTosFlag,
Expand Down
13 changes: 1 addition & 12 deletions config/features/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,14 +123,7 @@ func InitWithReset(c *Flags) func() {

// configureTestnet sets the config according to specified testnet flag
func configureTestnet(ctx *cli.Context) error {
if ctx.Bool(PraterTestnet.Name) {
log.Info("Running on the Prater Testnet")
if err := params.SetActive(params.PraterConfig().Copy()); err != nil {
return err
}
applyPraterFeatureFlags(ctx)
params.UsePraterNetworkConfig()
} else if ctx.Bool(SepoliaTestnet.Name) {
if ctx.Bool(SepoliaTestnet.Name) {
log.Info("Running on the Sepolia Beacon Chain Testnet")
if err := params.SetActive(params.SepoliaConfig().Copy()); err != nil {
return err
Expand All @@ -157,10 +150,6 @@ func configureTestnet(ctx *cli.Context) error {
return nil
}

// Insert feature flags within the function to be enabled for Prater testnet.
func applyPraterFeatureFlags(ctx *cli.Context) {
}

// Insert feature flags within the function to be enabled for Sepolia testnet.
func applySepoliaFeatureFlags(ctx *cli.Context) {
}
Expand Down
9 changes: 0 additions & 9 deletions config/features/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ import (
)

var (
// PraterTestnet flag for the multiclient Ethereum consensus testnet.
PraterTestnet = &cli.BoolFlag{
Name: "prater",
Usage: "Runs Prysm configured for the Prater / Goerli test network.",
Aliases: []string{"goerli"},
}
// SepoliaTestnet flag for the multiclient Ethereum consensus testnet.
SepoliaTestnet = &cli.BoolFlag{
Name: "sepolia",
Expand Down Expand Up @@ -183,7 +177,6 @@ var devModeFlags = []cli.Flag{
var ValidatorFlags = append(deprecatedFlags, []cli.Flag{
writeWalletPasswordOnWebOnboarding,
HoleskyTestnet,
PraterTestnet,
SepoliaTestnet,
Mainnet,
dynamicKeyReloadDebounceInterval,
Expand All @@ -208,7 +201,6 @@ var BeaconChainFlags = append(deprecatedBeaconFlags, append(deprecatedFlags, []c
saveInvalidBlobTempFlag,
disableGRPCConnectionLogging,
HoleskyTestnet,
PraterTestnet,
SepoliaTestnet,
Mainnet,
disablePeerScorer,
Expand Down Expand Up @@ -239,7 +231,6 @@ var E2EBeaconChainFlags = []string{
// NetworkFlags contains a list of network flags.
var NetworkFlags = []cli.Flag{
Mainnet,
PraterTestnet,
SepoliaTestnet,
HoleskyTestnet,
}
4 changes: 0 additions & 4 deletions config/params/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ go_library(
"network_config.go",
"testnet_e2e_config.go",
"testnet_holesky_config.go",
"testnet_prater_config.go",
"testnet_sepolia_config.go",
"testutils.go",
"testutils_develop.go", # keep
Expand Down Expand Up @@ -50,22 +49,19 @@ go_test(
"mainnet_config_test.go",
"testnet_config_test.go",
"testnet_holesky_config_test.go",
"testnet_prater_config_test.go",
],
data = glob(["*.yaml"]) + [
"testdata/e2e_config.yaml",
"@consensus_spec//:spec_data",
"@consensus_spec_tests_mainnet//:test_data",
"@consensus_spec_tests_minimal//:test_data",
"@eth2_networks//:configs",
"@goerli_testnet//:configs",
"@holesky_testnet//:configs",
],
embed = [":go_default_library"],
gotags = ["develop"],
tags = ["CI_race_detection"],
deps = [
"//build/bazel:go_default_library",
"//consensus-types/primitives:go_default_library",
"//encoding/bytesutil:go_default_library",
"//io/file:go_default_library",
Expand Down
1 change: 0 additions & 1 deletion config/params/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package params
func init() {
defaults := []*BeaconChainConfig{
MainnetConfig(),
PraterConfig(),
MinimalSpecConfig(),
E2ETestConfig(),
E2EMainnetTestConfig(),
Expand Down
2 changes: 1 addition & 1 deletion config/params/testdata/e2e_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ PROPOSER_SCORE_BOOST: 40

# Deposit contract
# ---------------------------------------------------------------
# Ethereum Goerli testnet
# Testnet
DEPOSIT_CHAIN_ID: 1337 # Override for e2e tests
DEPOSIT_NETWORK_ID: 1337 # Override for e2e tests
# Configured on a per testnet basis
Expand Down
49 changes: 0 additions & 49 deletions config/params/testnet_prater_config.go

This file was deleted.

28 changes: 0 additions & 28 deletions config/params/testnet_prater_config_test.go

This file was deleted.

2 changes: 0 additions & 2 deletions config/params/values.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ const (
MainnetName = "mainnet"
MainnetTestName = "mainnet-test"
MinimalName = "minimal"
PraterName = "prater"
GoerliName = "goerli"
SepoliaName = "sepolia"
HoleskyName = "holesky"
)
4 changes: 2 additions & 2 deletions io/logs/logutil_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ var urltests = []struct {
maskedUrl string
}{
{"https://a:[email protected]", "https://***@xyz.net"},
{"https://eth-goerli.alchemyapi.io/v2/tOZG5mjl3.zl_nZdZTNIBUzsDq62R_dkOtY",
"https://eth-goerli.alchemyapi.io/***"},
{"https://eth-holesky.alchemyapi.io/v2/tOZG5mjl3.zl_nZdZTNIBUzsDq62R_dkOtY",
"https://eth-holesky.alchemyapi.io/***"},
{"https://google.com/search?q=golang", "https://google.com/***"},
{"https://[email protected]/foo%2fbar", "https://***@example.com/***"},
{"http://[email protected]/#x/y%2Fz", "http://***@example.com/#***"},
Expand Down
2 changes: 1 addition & 1 deletion tools/eth1exporter/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var (

var (
port = flag.Int("port", 9090, "Port to serve /metrics")
web3URL = flag.String("web3-provider", "https://goerli.prylabs.net", "Web3 URL to access information about ETH1")
web3URL = flag.String("web3-provider", "https://holesky.prylabs.net", "Web3 URL to access information about ETH1")
prefix = flag.String("prefix", "", "Metrics prefix.")
addressFilePath = flag.String("addresses", "", "File path to addresses text file.")
)
Expand Down
2 changes: 1 addition & 1 deletion tools/eth1voting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Flags:
-beacon string
gRPC address of the Prysm beacon node (default "127.0.0.1:4000")
-genesis uint
Genesis time. mainnet=1606824023, prater=1616508000 (default 1606824023)
Genesis time. mainnet=1606824023, holesky=1695902400 (default 1606824023)
```

Usage:
Expand Down
2 changes: 1 addition & 1 deletion tools/eth1voting/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (

var (
beacon = flag.String("beacon", "127.0.0.1:4000", "gRPC address of the Prysm beacon node")
genesis = flag.Uint64("genesis", 1606824023, "Genesis time. mainnet=1606824023, prater=1616508000")
genesis = flag.Uint64("genesis", 1606824023, "Genesis time. mainnet=1606824023, holesky=1695902400")
)

func main() {
Expand Down
8 changes: 0 additions & 8 deletions tools/pcli/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,14 +209,6 @@ var stateTransitionCommand = &cli.Command{
Action: func(c *cli.Context) error {
if network != "" {
switch network {
case params.PraterName:
if err := params.SetActive(params.PraterConfig()); err != nil {
log.Fatal(err)
}
case params.GoerliName:
if err := params.SetActive(params.PraterConfig()); err != nil {
log.Fatal(err)
}
case params.SepoliaName:
if err := params.SetActive(params.SepoliaConfig()); err != nil {
log.Fatal(err)
Expand Down
2 changes: 0 additions & 2 deletions validator/accounts/accounts_exit.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,6 @@ func formatBeaconChaURL(key []byte) string {
keyWithout0x := hexutil.Encode(key)[2:]

switch env := params.BeaconConfig().ConfigName; env {
case params.PraterName, params.GoerliName:
return fmt.Sprintf(baseURL, "prater.", keyWithout0x)
case params.HoleskyName:
return fmt.Sprintf(baseURL, "holesky.", keyWithout0x)
case params.SepoliaName:
Expand Down
Loading

0 comments on commit 8cf5d79

Please sign in to comment.