-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Set parameter in M78 Statistics gcode #4809
Conversation
All values in bytes. Δ Delta to base
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is there is some confusion between centimeter and meter.
Fix few things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the filament usage SI units, and it looks like the EEPROM documentation was wrong. @3d-gussner you were right, the EEPROM value is in centimeters. 👍
There is one minor typo I found, but not a blocker.
Often a full factory reset is the best way to solve some issues. But that also means that the statistics are lost and often user complain why we can't keep them.
This is an attempt to give the user the option to get the statistics AND restore them if needed.
Added new parameters to
M78
to be able to restore statistics after a factory reset.Also added the output to
M503
Tested on MK404:
M78
a. Example response when LCD Statistics menu shows
4.75m
and0d 2h 6m
M75
to start the print timerTotal filament
andTotal print time
toFilament used
andPrint time
M78
after waiting at least 1 minutea. Example response when LCD Statistics menu show
0.00m
and0h 02m 05s
M77
to stop the print timerTotal
and you see the additional print time being added.M503
a. Example response in serial with total values being
4.75m
and `0d 02h 08mM78
and you seeM503
M78 S475 T128
M78
and also in serial output you see the restored values.Thanks to @crabbedh for the request #3448 sorry it took so long to be implemented.