-
Notifications
You must be signed in to change notification settings - Fork 32
Hotfix/change commit message length related guidelines #1581
base: master
Are you sure you want to change the base?
Hotfix/change commit message length related guidelines #1581
Conversation
The origin of the limitations was to allow comfortable reading of commits using the "git log" (and out aliases "gitlog") in the developer shell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this change.
I think that terminals and GUIs in development environment has more than 80 chars limitations.
Setting it to 100 is fine, it also forces a strict and accurate commit subject sentence.
@adam1985d can you add a screenshot to support your concerns?
Wrapping the commit descriptions at 72-75 characters is very common across open source projects, I don't really see the benefit of switching to 100... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change the limitation on the git commit subject to 72 which is the limit which passing it will cause GitHub to wrap the line with "...": "prefix: This is an example to a commit message subject that exceeding 72 c... arecters" Change the commit extended description length limitation to 100 characters. The git log looks fine with this limitation, and since we set the code line limitation to 100, there is no reason not to apply the same limitation on the commit message. Signed-off-by: Moran Shoeg <[email protected]>
Signed-off-by: Moran Shoeg <[email protected]>
bcde88d
to
63dd0af
Compare
Change the limitation on the git commit subject to 72 which is the limit which passing it
will cause GitHub to wrap the line with "...":
"prefix: This is an example to a commit message subject that exceeding 72 c...
arecters"
Change the commit extended description length limitation to 100 characters. The git log looks fine
with this limitation, and since we set the code line limitation to 100, there is no reason not to
apply the same limitation on the commit message.