Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Commit

Permalink
controller: db: fix function return value on success to true
Browse files Browse the repository at this point in the history
As part of testing the full flows of the persistent Db we encountered
an issue where a successful removal of a client entry from the
persistent DB resulted in a false-positive error.
The cause of this error is that remove_client_entry_and_update_counter()
in the db class returned false both for success and for failure.

Changed the successful return value of the above-mentioned function
from false to true.

Signed-off-by: Adam Dov <[email protected]>
  • Loading branch information
adam1985d committed Aug 2, 2020
1 parent 6275f9d commit 842bc5b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion controller/src/beerocks/master/db/db.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4415,7 +4415,7 @@ bool db::remove_client_entry_and_update_counter(const std::string &entry_name)
}
--m_persistent_db_clients_count;

return false;
return true;
}

bool db::remove_candidate_client()
Expand Down

0 comments on commit 842bc5b

Please sign in to comment.