Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rules_rust to v0.42.1 (with Rust v1.77.2). #410

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Update rules_rust to v0.42.1 (with Rust v1.77.2). #410

merged 4 commits into from
Aug 19, 2024

Conversation

keithmattix
Copy link
Contributor

As requested, split out the rules_rust update from #406

@keithmattix
Update rules_rust
31281ed 
Signed-off-by: Keith Mattix II <[email protected]>
@keithmattix keithmattix mentioned this pull request Aug 16, 2024
Merged
PiotrSikora
PiotrSikora reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run buildifier and also regenerate cargo universe rules.

bazel/repositories.bzl Outdated Show resolved Hide resolved
bazel/external/rules_rust.patch Show resolved Hide resolved
@PiotrSikora PiotrSikora changed the title Update rules_rust Update rules_rust to v0.42.1. Aug 16, 2024
PiotrSikora
PiotrSikora reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update Rust version in bazel/dependencies.bzl.

@keithmattix
Update rust and vendor
0fd7cd2 
Signed-off-by: Keith Mattix II <[email protected]>
@keithmattix
Copy link
Contributor Author

Thanks for the quick feedback @PiotrSikora! Done

@PiotrSikora
Copy link
Member

The rust_oom -> rg_oom change is missing.

@keithmattix
rust_oom -> rg_oom
51df141 
Signed-off-by: Keith Mattix II <[email protected]>
@keithmattix
Copy link
Contributor Author

Ah, I was testing with wasmtime locally. Thanks for continuously kicking off CI

PiotrSikora
PiotrSikora reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sans Rust version discrepancy.

bazel/dependencies.bzl Outdated Show resolved Hide resolved
@keithmattix
Change rust version
59069e7 
Signed-off-by: Keith Mattix II <[email protected]>
@PiotrSikora PiotrSikora changed the title Update rules_rust to v0.42.1. Update rules_rust to v0.42.1 (with Rust v1.77.2). Aug 16, 2024
PiotrSikora
PiotrSikora approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mpwarres mpwarres merged commit f199214 into proxy-wasm:main Aug 19, 2024
31 checks passed
@PiotrSikora PiotrSikora mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

@martijneken martijneken Awaiting requested review from martijneken martijneken is a code owner

@mpwarres mpwarres Awaiting requested review from mpwarres mpwarres is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithmattix @PiotrSikora @mpwarres