Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update v8 to 12.7.224.18 #409

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

build: update v8 to 12.7.224.18 #409

wants to merge 25 commits into from

Commits on Aug 18, 2024

  1. Compile with C++20 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    644e5e2 View commit details
    Browse the repository at this point in the history

  2. Update googletest to v1.15.2 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    fdb5e93 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Patch proxy-wasm-cpp-sdk to work around g++ -std=c++20 compilation issue 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    aab1611 View commit details
    Browse the repository at this point in the history

  2. Add temporary workaround for proxy-wasm#412 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    749ebf8 View commit details
    Browse the repository at this point in the history

  3. Add -fno-sanitize=unsigned-integer-overflow to clang asan options 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    fc7a80b View commit details
    Browse the repository at this point in the history

  4. Disable clang-tidy clang-diagnostic-builtin-macro-redefined check 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c2f8102 View commit details
    Browse the repository at this point in the history

  5. Change asan config for NullVM and Wasmtime from clang-asan-strict to … 

    …clang-asan

Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d7d6af7 View commit details
    Browse the repository at this point in the history

  6. v8: update to 12.7.224.18 

    - Update v8.patch
- Remove v8_include.patch which is no longer needed
- Remove dependency on chromium_base_trace_event_common

Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5092179 View commit details
    Browse the repository at this point in the history

  7. Update v8.patch to revert v8 commit b26554ec368e9553782012c96aa5e99b1… 

    …63eaff2

This re-adds the use of _allowlist_function_transition, which is needed by
Bazel 6.5.0.

Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ce012d6 View commit details
    Browse the repository at this point in the history

  8. Bind absl_* build targets referenced by v8 build rules 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4614adf View commit details
    Browse the repository at this point in the history

  9. Fetch fp16 dependency of v8, and patch v8 to find it 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ef3558a View commit details
    Browse the repository at this point in the history

  10. Set torque generator path to location where Bazel can find outputs 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7a25b87 View commit details
    Browse the repository at this point in the history

  11. Tolerate deprecated declarations in v8 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a65d5e9 View commit details
    Browse the repository at this point in the history

  12. Build with C++20, and take 2 at compiling v8 with -Wno-deprecated-dec… 

    …larations

Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bf4df28 View commit details
    Browse the repository at this point in the history

  13. Fix tweak to where v8 looks for its fp16 dependency 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    42d7ee7 View commit details
    Browse the repository at this point in the history

  14. Additionally specify --host_cxxopt=-std=c++20 

    This isn't strictly necessary in this PR for CI to pass, however I encountered
a need for it in child PR proxy-wasm#409, and seemed more appropriate to add here.

Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    93358c2 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'use-cpp-20' into v8_v12.7.224.18 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c1161ce View commit details
    Browse the repository at this point in the history

  16. Specify -Wno-invalid-offsetof for gcc builds 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    394f075 View commit details
    Browse the repository at this point in the history

  17. Cherrypick V8 commit 35888fee7bbaaaf1f02ccc88a95c9a336fc790bc to addr… 

    …ess gcc build failure

Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e5407f4 View commit details
    Browse the repository at this point in the history

  18. Use --cxxopt instead of --copt to specify -Wno-invalid-offsetof 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c4500ac View commit details
    Browse the repository at this point in the history

  19. Add -Wno-deprecated to gcc cxxopt 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8f34e8f View commit details
    Browse the repository at this point in the history

  20. Merge branch 'main' into use-cpp-20 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4de318c View commit details
    Browse the repository at this point in the history

  21. Merge branch 'use-cpp-20' into v8_v12.7.224.18 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    abc9b10 View commit details
    Browse the repository at this point in the history

  22. Specify -Wno-deprecated for gcc, take 2 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d4eec14 View commit details
    Browse the repository at this point in the history

  23. Set gcc warning flags via --host_cxxopt as well 

    Signed-off-by: Michael Warres <[email protected]>
    @mpwarres
    mpwarres committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    06f6411 View commit details
    Browse the repository at this point in the history