BE: Chore: Fix OauthAuthorityExtractor logging #3900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haarolean
added
scope/backend
type/chore
iliax
approved these changes
Jun 6, 2023
iliax
approved these changes
Jun 6, 2023
| @@ -72,16 +72,15 @@ public Mono<Set<String>> extract(AccessControlService acs, Object value, Map<Str | |||
| var principalRoles = convertRoles(principal.getAttribute(rolesFieldName)); | |||
| var roleMatched = principalRoles.contains(roleName); | |||
|
|
|||
| if (roleMatched) { | |||
| log.debug("Assigning role [{}] to user [{}]", roleName, principal.getName()); | |||
There was a problem hiding this comment.
maybe we should log both cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)