Fix up missing notes when using an ingress #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cadnce hi there, as this repo is not maintained (provectus/kafka-ui#4255), can I suggest you raise one at https://github.com/kafbat/helm-charts/ instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying this chart I noticed that I got a broken/incomplete output message.
It looks like at the time this was developed it was uncertain if hosts should be a list or single path.
How does the following fix strike you?
I've also added a comment about setting the config value
SERVER_SERVLET_CONTEXT_PATHfor when the server is running at a subpath as this tripped me up when testing this.